Skip to content

feat: Update TTL language to Time until shutdown #1948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 2, 2022

Conversation

AbhineetJain
Copy link
Contributor

@AbhineetJain AbhineetJain commented Jun 1, 2022

This PR updates the copy of TTL in frontend to Time until shutdown.

Subtasks

  • update the language of the label and helptext.

Fixes #1784

Screenshot

image

@AbhineetJain AbhineetJain requested a review from a team as a code owner June 1, 2022 15:02
Co-authored-by: Presley Pizzo <1290996+presleyp@users.noreply.github.com>
Copy link
Contributor

@greyscaled greyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me

@AbhineetJain AbhineetJain merged commit c463e78 into main Jun 2, 2022
@AbhineetJain AbhineetJain deleted the abhineetjain/1784-update-ttl-language branch June 2, 2022 14:15
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
* feat: update ttl language in frontend

* Update TTL Helper text

Co-authored-by: Presley Pizzo <1290996+presleyp@users.noreply.github.com>

* update TTL helper string

Co-authored-by: Presley Pizzo <1290996+presleyp@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: rename auto-off TTL in UI to normal English
5 participants