Skip to content

feat(enterprise/coderd): allow system users to be added to groups #19518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Aug 27, 2025
Merged

feat(enterprise/coderd): allow system users to be added to groups #19518

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
6b3a731
Allow users to view and modify group membership for the prebuilds sys…
SasSwart Jun 12, 2025
4b63826
Fix Tests
SasSwart Jun 12, 2025
90b9078
Merge remote-tracking branch 'origin/main' into jjs/prebuilds-user-gr…
SasSwart Jul 14, 2025
af7c7cd
fix tests
SasSwart Jul 15, 2025
1cd68e3
create a prebuilds group in every org that needs it
SasSwart Jul 29, 2025
4c0c4d4
Merge remote-tracking branch 'origin/main' into jjs/prebuilds-user-gr…
SasSwart Jul 29, 2025
93c46e9
add lint rule
SasSwart Jul 29, 2025
b3728d3
add quotas tests to verify prebuilds behaviour
SasSwart Jul 30, 2025
efdfe9f
fix unit test context
SasSwart Jul 30, 2025
8204ec2
revert broken query changes
SasSwart Aug 4, 2025
92760d1
make gen
SasSwart Aug 4, 2025
471c29e
Merge remote-tracking branch 'origin/main' into jjs/prebuilds-user-gr…
SasSwart Aug 6, 2025
f9a5fbb
Hide system users
SasSwart Aug 6, 2025
959c89e
remove prototype snippet
SasSwart Aug 6, 2025
1da8e34
refactor prebuilds reconciliation test
SasSwart Aug 6, 2025
cf6ee1c
check whether a prebuilds group exists before adding it
SasSwart Aug 25, 2025
b685245
make fmt
SasSwart Aug 25, 2025
e828366
Merge remote-tracking branch 'origin/main' into jjs/prebuilds-user-gr…
SasSwart Aug 25, 2025
adf7657
fix: rename constant to match validation
SasSwart Aug 25, 2025
820cfd6
Update enterprise/coderd/prebuilds/membership_test.go
SasSwart Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove prototype snippet
  • Loading branch information
@SasSwart
SasSwart committed Aug 6, 2025
commit 959c89e55e2648ea87cd07c8de7081953b6a0ede
7 changes: 1 addition & 6 deletions enterprise/coderd/prebuilds/membership.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,12 +112,7 @@ func (s StoreMembershipReconciler) ReconcileAll(ctx context.Context, userID uuid
}
}

// // Add the system user to the prebuilds group
// // TODO: Sas Look into this:
// groupMembers, err := s.store.GetGroups(ctx, database.GetGroupsParams{
// OrganizationID: preset.OrganizationID,
// HasMemberID: userID,
// })
// Add the system user to the prebuilds group
err = s.store.InsertGroupMember(ctx, database.InsertGroupMemberParams{
GroupID: prebuildsGroup.ID,
UserID: userID,
Expand Down
Loading