Skip to content

fix: fix flake in TestPatchCancelWorkspaceBuild/User_is_allowed_to_cancel #19522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 28, 2025
Merged

fix: fix flake in TestPatchCancelWorkspaceBuild/User_is_allowed_to_cancel #19522

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a428d12
test: add sleep interval in TestPatchCancelWorkspaceBuild
kacpersaw Aug 25, 2025
9b37924
Merge branch 'main' into kacpersaw/fix-flaky-workspace-cancel
kacpersaw Aug 25, 2025
78eecfb
instead of sleep use eventually
kacpersaw Aug 27, 2025
2be38fc
Merge branch 'main' into kacpersaw/fix-flaky-workspace-cancel
kacpersaw Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
instead of sleep use eventually
  • Loading branch information
@kacpersaw
kacpersaw committed Aug 27, 2025
commit 78eecfbb832cdc2fdbffedc53dcab8367d7a33b1
7 changes: 4 additions & 3 deletions coderd/workspacebuilds_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,10 +578,11 @@ func TestPatchCancelWorkspaceBuild(t *testing.T) {
return assert.NoError(t, err) && build.Job.Status == codersdk.ProvisionerJobRunning
}, testutil.WaitShort, testutil.IntervalFast)

time.Sleep(testutil.IntervalMedium)
require.Eventually(t, func() bool {
err := client.CancelWorkspaceBuild(ctx, build.ID, codersdk.CancelWorkspaceBuildParams{})
return assert.NoError(t, err)
}, testutil.WaitShort, testutil.IntervalMedium)

err := client.CancelWorkspaceBuild(ctx, build.ID, codersdk.CancelWorkspaceBuildParams{})
require.NoError(t, err)
require.Eventually(t, func() bool {
var err error
build, err = client.WorkspaceBuild(ctx, build.ID)
Expand Down