fix: add support for spaces in search & enable searching by display name in templates #19552
Conversation
|
Can we fallback to the |
To make sure I'm following would you like to search on That can be done. Since we would now support spaces in the search queries we'd probably need to update the |
Yes |
Sounds good! Defaulting to |
|
Nor directly related but is it possible to stop showing Can it be a hidden default filter that's always true. If someone wants deprecated templates they can set it to |
We could remove that from the frontend as the default query and update the query to always return Should we make a new issue for this work? |
|
Yes let's create a new issue. Thanks |
Summary
In this pull request we're updating search to support queries with spaces in addition to the
field:valuepattern that is currently supported.Additionally templates search now defaults to
display_name(sincedisplay_nameis optional the search will fallback toname) when searching without thefield:valuepatternCloses: #14384
Downsides with searching on
nameanddisplay_nameBecause the
namefield cannot include spaces, we end up in a situation where including a space in the query will result in no results since the query searches on bothnameANDdisplay_name. In the following example, we can see the results of searching by bothnameanddisplay_nameon these templates:name-and-display-name.mov
Proposal: Search on
display_nameby default and allow fornameusing thefield:valuepatternIf we remove
namefrom the default template search, we're now able to search with spaces on templatedisplay_names. Sincedisplay_namesare what users see in the templates list they might expect the search to work this way.Below is an example of
namebeing removed from the default template search.display-name.mov
With this approach users would still be able to search on template names by specifying
exact_name:foo.Testing
Added additional test cases to ensure spaces were handled as expected in combination with
field:valuepatterns.