feat: add coder_workspace_read_file MCP tool #19562
Merged
+678
−116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7bda4fd to
2828b76
Compare
2828b76 to
aae3033
Compare
This will be used in multiple tools.
aae3033 to
2972507
Compare
2972507 to
a042936
Compare
ThomasK33
reviewed
Sep 8, 2025
ThomasK33
approved these changes
Sep 8, 2025
codersdk/workspacesdk/agentconn.go
Outdated
Comment on lines
488
to
490
| // Ideally we could stream this all the way back, but it looks like the MCP | ||
| // interfaces only allow returning full responses which means the whole thing | ||
| // has to be read into memory. So, add a maximum to compensate. |
There was a problem hiding this comment.
We might want to implement the buffering in the MCP server/toolsdk and keep this part as a streaming response. Functionality-wise, this should remain the same.
There was a problem hiding this comment.
100% agree. Will change.
There was a problem hiding this comment.
Let me know if you want another review; otherwise, it's good to merge with that change from my POV.
1d4cd78 to
f903423
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows similarly to the bash tool (and some code to connect to an agent was extracted from it).
There are two main parts: a new agent endpoint, and then a new MCP tool that consumes that endpoint.