chore: refactor instance identity to be a SessionTokenProvider #19566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1b453cd to
421347b
Compare
6f7bb8d to
ad7200f
Compare
421347b to
7b1affe
Compare
7789799 to
d9ee61f
Compare
7b1affe to
a13a334
Compare
ad45ac9 to
ce4943c
Compare
53e1b76 to
7ea81d2
Compare
mafredri
reviewed
Aug 29, 2025
| @@ -0,0 +1,97 @@ | |||
| package agentsdk | |||
There was a problem hiding this comment.
Suggestion (optional): Consider moving into sub-package, assuming there aren't any blocking dependencies to this package that would cause a circular import.
ce4943c to
608b392
Compare
7ea81d2 to
192c81e
Compare
59667e7 to
54f6878
Compare
54f6878 to
6cddf93
Compare
mafredri
approved these changes
Sep 2, 2025
| @@ -220,7 +224,7 @@ func (r *RootCmd) Command(subcommands []*serpent.Command) (*serpent.Command, err | |||
| // with a `gitaskpass` subcommand, we override the entrypoint | |||
| // to check if the command was invoked. | |||
| if gitauth.CheckCommand(i.Args, i.Environ.ToOS()) { | |||
| return r.gitAskpass().Handler(i) | |||
| return gitAskpass(hiddenAgentAuth).Handler(i) | |||
6cddf93 to
68c9194
Compare
Merge activity
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors Agent instance identity to be a SessionTokenProvider.
Refactors the CLI to create Agent clients via a centralized function, rather than add-hoc via individual command handlers and their flags.
This allows commands besides
coder agent, but which still use the agent identity, to support instance identity authentication.Fixes #19111 by unifying all API requests to go thru the SessionTokenProvider for auth credentials.