fix: don't show prebuild workspaces as tasks #19572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parkreiner
approved these changes
Aug 27, 2025
site/src/api/api.ts
Outdated
Comment on lines
2707
to
2709
| }).then((res) => | ||
| res.workspaces.filter((workspace) => !workspace.is_prebuild), | ||
| ); |
There was a problem hiding this comment.
Nit: I know this is valid, but I feel like if we're going to be using await syntax, we shouldn't be using promise-chaining in the same function scope, just for consistency
There was a problem hiding this comment.
Also, could we add a comment giving some extra context for why we're filtering pre-builds out?
code-asher
approved these changes
Aug 27, 2025
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19570
Before:
After:
Things to notice: