feat: add sharing add command to the CLI
#19576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3ff3630 to
a88364c
Compare
|
Let's add |
sharing share command to the CLIsharing add command to the CLI
rafrdz
requested changes
Sep 4, 2025
| } | ||
|
|
||
| for _, user := range users { | ||
| userAndRole := nameRoleRegex.FindStringSubmatch(user) |
There was a problem hiding this comment.
In the event that this is nil can we add a check to prevent a panic?
Suggested change
| userAndRole := nameRoleRegex.FindStringSubmatch(user) | |
| userAndRole := nameRoleRegex.FindStringSubmatch(user) | |
| if userAndRole == nil { | |
| return xerrors.Errorf("invalid user format %q: must match pattern 'username:role'", user) | |
| } |
| } | ||
|
|
||
| for _, group := range groups { | ||
| groupAndRole := nameRoleRegex.FindStringSubmatch(group) |
There was a problem hiding this comment.
Similar validation question to userAndRole here
rafrdz
approved these changes
Sep 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
sharing addcommand for sharing Workspaces with other users and groups.The command allows sharing with multiple users, and groups within one command as well as specifying the role (
use, oradmin) defaulting touseif none is specified.In the current implementation when the command completes we show the user the current state of the workspace ACL.
If a user is a part of multiple groups, or the workspace has been individually shared with them they will show up multiple times. Although this is a bit confusing at first glance it's important to be able to tell what the maximum role a user may have, and via what ACL they have it.
One piece of UX to consider is that in order to be able to share a Workspace with a user they must have a role that can read that user. In the tests we give the user the
ScopedRoleOrgAuditorrole.Closes coder/internal#859