chore: refactor CLI agent auth tests as unit tests #19609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 28, 2025
This stack of pull requests is managed by Graphite. Learn more about stacking. |
46dfec7 to
07bb100
Compare
07bb100 to
faa0ebf
Compare
faa0ebf to
07f5bc3
Compare
a13a334 to
ad45ac9
Compare
07f5bc3 to
9f9cd09
Compare
ad45ac9 to
ce4943c
Compare
mafredri
approved these changes
Aug 29, 2025
608b392 to
e5bf69b
Compare
9f9cd09 to
3fbbf99
Compare
e5bf69b to
59667e7
Compare
3fbbf99 to
06d66ae
Compare
59667e7 to
54f6878
Compare
06d66ae to
5797ad5
Compare
54f6878 to
6cddf93
Compare
5797ad5 to
640542d
Compare
6cddf93 to
68c9194
Compare
640542d to
5f400e4
Compare
5f400e4 to
7690732
Compare
68c9194 to
1354d84
Compare
7690732 to
eec060e
Compare
Merge activity
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes coder/internal#933
Refactors CLI tests that check the
--authflag parsing for various public clouds into a unit test that just creates the agent Client and asserts on the type.Testing that the agent client actually authenticates correctly with these auth types is well covered by Coderd tests, so we don't need to retread that ground here, and the deleted tests were flaky on Windows.