-
Notifications
You must be signed in to change notification settings - Fork 978
docs: replace offline deployments terminology to air-gapped #19625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Change title from 'Offline Deployments' to 'Air-gapped Deployments' - Update summary to prioritize 'air-gapped' and add 'disconnected' - Change table header from 'Offline deployments' to 'Air-gapped deployments' - Update tutorial reference to use 'air-gapped' terminology - Update section header to 'Air-gapped container images' This improves clarity by using the more precise 'air-gapped' terminology and includes 'disconnected' to cover additional deployment scenarios.
The markdown table formatter was removing trailing spaces from the 'Air-gapped deployments' column header, causing CI failures.
Confirmed with Ross W, and he’s aligned on this change. |
- Update manifest.json to change navigation title from 'Offline Deployments' to 'Air-gapped Deployments' - Update description to prioritize 'air-gapped' terminology - Fix line break issues in the markdown file This ensures the navigation, breadcrumbs, and page title all consistently use 'Air-gapped Deployments'.
- Rename docs/install/offline.md to docs/install/airgap.md for consistency - Update manifest.json path to point to ./install/airgap.md - Update all internal links from install/offline to install/airgap - Add redirect configuration for /install/offline -> /install/airgap - Updated files: integrations/index.md, networking/index.md, changelogs/v0.27.0.md, faqs.md This ensures complete consistency with the new 'air-gapped' terminology while maintaining backward compatibility through redirects.
- Update 'Offline docs' section header to 'Air-gapped docs' - Add redirects for anchor fragments: - /install/offline#offline-docs -> /install/airgap#airgap-docs - /install/offline#offline-container-images -> /install/airgap#airgap-container-images - Update changelog reference to use new airgap-docs anchor This ensures complete URL consistency including subsection anchors while maintaining backward compatibility for deep links.
Removed /install/offline.md redirect as users don't typically access raw markdown files directly. Kept the essential redirects: - Main page: /install/offline -> /install/airgap - Subsection anchors for deep links
Changed 'offline documentation' to 'air-gapped documentation' in the Air-gapped docs section for complete terminology consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed a few missed mentions.
docs/admin/integrations/index.md
Outdated
@@ -13,6 +13,6 @@ our [installation guides](../../install/index.md). | |||
The following resources may help as you're deploying Coder. | |||
|
|||
- [Coder packages: one-click install on cloud providers](https://github.com/coder/packages) | |||
- [Deploy Coder offline](../../install/offline.md) | |||
- [Deploy Coder offline](../../install/airgap.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [Deploy Coder offline](../../install/airgap.md) | |
- [Deploy Coder Air-gapped](../../install/airgap.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Fixed! Updated to "Deploy Coder Air-gapped" along with several other missed mentions I found throughout the docs.
docs/admin/networking/index.md
Outdated
@@ -116,12 +116,12 @@ If a direct connection is not available (e.g. client or server is behind NAT), | |||
Coder will use a relayed connection. By default, | |||
[Coder uses Google's public STUN server](../../reference/cli/server.md#--derp-server-stun-addresses), | |||
but this can be disabled or changed for | |||
[offline deployments](../../install/offline.md). | |||
[offline deployments](../../install/airgap.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[offline deployments](../../install/airgap.md). | |
[Air-gapped deployments](../../install/airgap.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Fixed! Updated to "Air-gapped deployments" here and found several other instances throughout the docs that needed the same update.
Updated remaining instances to use 'air-gapped deployments' terminology: - integrations/index.md: 'Deploy Coder offline' -> 'Deploy Coder Air-gapped' - networking/index.md: Multiple 'offline deployments' -> 'Air-gapped deployments' - jfrog-artifactory.md: Section header and text updated - changelogs/v2.8.0.md: Changelog entry updated Thanks to @matifali for catching these missed references!
Fixed punctuation in the opening sentence of the air-gapped deployments page.
Fixes lint failure - files must end with a newline character.
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
This PR comprehensively updates the offline deployments documentation to use more precise "air-gapped" terminology and improves consistency throughout the documentation.
Changes Made
Terminology Updates
Navigation & URL Structure
docs/manifest.json
to show "Air-gapped Deployments" in sidebardocs/install/offline.md
→docs/install/airgap.md
for consistency/install/offline
→/install/airgap
/install/offline#offline-docs
→/install/airgap#airgap-docs
/install/offline#offline-container-images
→/install/airgap#airgap-container-images
Internal Links & References
Updated all internal documentation links:
docs/admin/integrations/index.md
docs/admin/networking/index.md
docs/changelogs/v0.27.0.md
(including anchor reference)docs/tutorials/faqs.md
Backward Compatibility
docs/_redirects
with 301 redirects:/install/offline
→/install/airgap
/install/offline#offline-docs
→/install/airgap#airgap-docs
/install/offline#offline-container-images
→/install/airgap#airgap-container-images
Rationale
Testing
Result
Complete terminology consistency across: