feat: add coder_workspace_edit_file MCP tool #19629
Open
+758
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2ba812 to
5b5b443
Compare
91c875b to
9435706
Compare
8c658eb to
13e42f0
Compare
13e42f0 to
d231994
Compare
9435706 to
d82a0ff
Compare
d82a0ff to
1f7ae1f
Compare
ThomasK33
reviewed
Sep 10, 2025
Comment on lines
+528
to
+531
| type FileEdit struct { | ||
| Search string `json:"search"` | ||
| Replace string `json:"replace"` | ||
| } |
There was a problem hiding this comment.
Would it make sense to include a file path here as well?
This way, one could bundle multiple file writes or perform bulk operations into a single API call.
We can still have a tool that edits a single file, but internally, it could bundle the path and call it the multi-file edit one.
Comment on lines
+232
to
+234
| if len(edits) == 0 { | ||
| return http.StatusBadRequest, xerrors.New("must specify at least one edit") | ||
| } |
There was a problem hiding this comment.
Shouldn't this check be moved to the top?
Comment on lines
+248
to
+249
| if err != nil { | ||
| return http.StatusInternalServerError, xerrors.Errorf("edit %s: %w", path, err) |
There was a problem hiding this comment.
Shouldn't we clean up the tmpfile if the copy failed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation from #19591