chore: replace GetManagedAgentCount query with aggregate table #19636
+488
−116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes GetManagedAgentCount query - Adds new table `usage_events_daily` which stores aggregated usage events by the type and UTC day - Adds trigger to update the values in this table when a new row is inserted into `usage_events` - Adds a migration that adds `usage_events_daily` rows for existing data in `usage_events` Since the `usage_events` table is unreleased currently, this migration will do nothing on real deployments and will only affect preview deployments such as dogfood.
johnstcn
reviewed
Aug 29, 2025
| RETURNS TRIGGER AS $$ | ||
| BEGIN | ||
| -- Check for supported event types and throw error for unknown types | ||
| IF NEW.event_type NOT IN ('dc_managed_agents_v1') THEN |
There was a problem hiding this comment.
My main worry with this is that if some bad code spams insertion of unknown usage events we could end up creating some serious DB load. IIRC you make it fairly difficult to even do that though, so I guess this is OK?
There was a problem hiding this comment.
I imagine it would generate a lot of load anyway if something like that was happening. This upsert should be fairly quick since it's using the primary key.
I also don't know how else I'd handle this other than a cronjob, which would also generate a lot of load if there was a lot of rows, and would require a new Go package to handle doing it every once in a while.
johnstcn
approved these changes
Aug 29, 2025
There was a problem hiding this comment.
reminder to check migration number before merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
usage_events_dailywhich stores aggregated usage events by the type and UTC dayusage_eventsusage_events_dailyrows for existing data inusage_eventsSince the
usage_eventstable is unreleased currently, this migration will do nothing on real deployments and will only affect preview deployments such as dogfood.Closes coder/internal#943