Skip to content

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Aug 29, 2025

No description provided.

@Emyrk Emyrk added the cherry-pick/v2.26 Needs to be cherry-picked to the 2.26 release branch label Aug 29, 2025
@Emyrk Emyrk requested a review from johnstcn August 29, 2025 12:11
@Emyrk Emyrk force-pushed the stevenmasley/preview_1_0_4 branch from f3f197d to f05ba15 Compare August 30, 2025 11:12
@Emyrk
Copy link
Member Author

Emyrk commented Aug 30, 2025

This flake keeps failing: #19654

A dep update probably changed the timing. So need to merge the flake fix first.

@ethanndickson
Copy link
Member

ethanndickson commented Sep 2, 2025

A dep update probably changed the timing. So need to merge the flake fix first.

It was the testify dep bump, I fixed it in #19599, this PR should be good after a rebase.

@sreya sreya merged commit f571730 into main Sep 2, 2025
31 checks passed
@sreya sreya deleted the stevenmasley/preview_1_0_4 branch September 2, 2025 19:01
@github-actions github-actions bot locked and limited conversation to collaborators Sep 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cherry-pick/v2.26 Needs to be cherry-picked to the 2.26 release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants