Skip to content

fix(coderd): fix logic for reporting prebuilt workspace duration metric #19641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 29, 2025
Merged

fix(coderd): fix logic for reporting prebuilt workspace duration metric #19641

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1631ffd
fix: prebuilt workspace creation duration metric
ssncferreira Aug 29, 2025
adf2319
chore: address comments
ssncferreira Aug 29, 2025
44e3e0f
Merge remote-tracking branch 'origin/main' into ssncferreira/fix-preb…
ssncferreira Aug 29, 2025
9df0d6c
chore: add comment to db.UpdateWorkspaceAgentLifecycleStateByID
ssncferreira Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: add comment to db.UpdateWorkspaceAgentLifecycleStateByID
  • Loading branch information
@ssncferreira
ssncferreira committed Aug 29, 2025
commit 9df0d6cb36762642634f928bebd0d8788ecb3563
3 changes: 3 additions & 0 deletions enterprise/coderd/coderdenttest/coderdenttest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,9 @@ func GetRunningPrebuilds(
agents, err := db.GetWorkspaceAgentsInLatestBuildByWorkspaceID(ctx, prebuild.ID)
assert.NoError(t, err, "failed to get agents")

// Manually mark all agents as ready since tests don't have real agent processes
// that would normally report their lifecycle state. Prebuilt workspaces are only
// eligible for claiming when their agents reach the "ready" state.
for _, agent := range agents {
err = db.UpdateWorkspaceAgentLifecycleStateByID(ctx, database.UpdateWorkspaceAgentLifecycleStateByIDParams{
ID: agent.ID,
Expand Down
Loading