Skip to content

fix: add bottom padding to workspace page #19643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2025
Merged

fix: add bottom padding to workspace page #19643

merged 1 commit into from
Sep 3, 2025

Conversation

brettkolodny
Copy link
Contributor

@brettkolodny brettkolodny commented Aug 29, 2025 •
edited
Loading

Before:
CleanShot 2025-08-29 at 11 58 56@2x

After:

CleanShot 2025-08-29 at 11 59 14@2x

@brettkolodny brettkolodny marked this pull request as ready for review August 29, 2025 15:57
aslilac
aslilac approved these changes Sep 2, 2025
View reviewed changes
Copy link
Member

@aslilac aslilac left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

laughing a bit at the Margins component needing padding.

we use this component in a few places. I wonder if other pages would benefit from this change as well. maybe we could just update the Margins component itself.

this is fine for now tho!

@brettkolodny
Copy link
Contributor Author

Yeah, I think in general the pages need to be a bit more standardized which will make being consistent much easier

@brettkolodny brettkolodny merged commit 6606d8b into main Sep 3, 2025
38 checks passed
@brettkolodny brettkolodny deleted the brett/improve-more-scrolling branch September 3, 2025 00:16
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aslilac aslilac aslilac approved these changes

@Parkreiner Parkreiner Awaiting requested review from Parkreiner Parkreiner is a code owner

Assignees

@brettkolodny brettkolodny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brettkolodny @aslilac