chore(cli): re-order CLI create command #19658
Conversation
86adf7a to
0fe358d
Compare
Relates to coder/internal#893 Instead of `coder task create <template> --input <input>`, it is now `coder task create <input> --template <template>`. If there is only one AI task template on the deployment, the `--template` parameter can be omitted.
0fe358d to
3071ef8
Compare
| Flag: "input", | ||
| Env: "CODER_TASK_INPUT", | ||
| Value: serpent.StringOf(&taskInput), | ||
| Required: true, |
There was a problem hiding this comment.
Does it mean we can start a task without an input? i.e., an empty prompt? Should we allow that?
There was a problem hiding this comment.
I think this may end up happening in a prebuild scenario?
There was a problem hiding this comment.
Maybe, yes. Prebuilds are tricky.
There was a problem hiding this comment.
I don't think we should start tasks without input necessarily, but who's to say there isn't a default input that's only controlled by e.g. template parameters. This was one motivation that --input was made a flag previously.
There was a problem hiding this comment.
Have added a check to disallow empty task input
No need, this is exactly why we placed these under |
But many of our customers are using Tasks. So I was just being extra cautious not to break their workflows without any information. |
I don't have a strong opinion. We don't document |
We can if you feel it's necessary. Just bear in mind the output of
|
It was merged on Friday so I don't think so |
Thanks, then I don't see any reason to tag this breaking. 👍🏻 |
|
All good then Thanks all. |
In the scenario where both a template name and a template version were provided, we'd hit the database twice, depsite only needing to do it once.
Relates to coder/internal#893
Instead of
coder task create <template> --input <input>, it is nowcoder task create <input> --template <template>.If there is only one AI task template on the deployment, the
--templateparameter can be omitted.