fix(coderd): ensure a newly created task can be fetched #19670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to how we currently label a workspace as a task, there is a delay between when a task workspace is created and when it is labelled as a task. This PR introduces fallback check for when a workspace does _not_ have `HasAITask` set. This fallback check tests to see if the special "AI Prompt" parameter is present in the workspace's build parameters.
c8583d8 to
caf9000
Compare
DanielleMaywood
commented
Sep 2, 2025
| @@ -253,7 +253,6 @@ func TestTasks(t *testing.T) { | |||
| {Name: codersdk.AITaskPromptParameterName, Value: wantPrompt}, | |||
| } | |||
| }) | |||
| coderdtest.AwaitWorkspaceBuildJobCompleted(t, client, workspace.LatestBuild.ID) | |||
There was a problem hiding this comment.
Removing this call effectively tests that we can fetch a task prior to the build job being finished
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to how we currently label a workspace as a task, there is a delay between when a task workspace is created and when it is labelled as a task.
This PR introduces fallback check for when a workspace does not have
HasAITaskset. This fallback check tests to see if the special "AI Prompt" parameter is present in the workspace's build parameters.