Skip to content

Conversation

stirby
Copy link
Collaborator

@stirby stirby commented Sep 4, 2025

Cherry-pick for release v2.24.4.
#19696

The latest release of all `pg_dump` major versions, going back to 13,
started inserting `\restrict` `\unrestrict` keywords into dumps. This
currently breaks sqlc in `gen/dump` and our check migration script. Full
details of the postgres change are available here:
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=575f54d4c

To fix, we'll always use the `pg_dump` in our postgres 13.21 docker
image for schema dumps, instead of what's on the runner/local machine.

Coder doesn't restore from postgres dumps, so we're not vulnerable to
attacks that would be patched by the latest postgres version.
Regardless, we'll unpin ASAP.

Once sqlc is updated to handle these keywords, we need to start
stripping them when comparing the schema in the migration check script,
and then we can unpin the pg_dump version. This is being tracked at
coder/internal#965

(cherry picked from commit 1b4ce09)
Copy link

github-actions bot commented Sep 4, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@stirby stirby changed the base branch from main to release/2.24 September 4, 2025 04:06
@stirby stirby requested a review from ethanndickson September 4, 2025 04:06
@stirby stirby changed the title fix: pin pg_dump version when generating schema (#19696) fix: pin pg_dump version when generating schema for 2.24 Sep 4, 2025
@stirby stirby merged commit ecc6d53 into release/2.24 Sep 4, 2025
13 of 14 checks passed
@stirby stirby deleted the cherry-pick-pg-24 branch September 4, 2025 04:09
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants