Skip to content

feat: add sharing show command to the CLI #19707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 8, 2025
Merged

feat: add sharing show command to the CLI #19707

merged 3 commits into from
Sep 8, 2025

Conversation

brettkolodny
Copy link
Contributor

@brettkolodny brettkolodny commented Sep 4, 2025 •
edited
Loading

@brettkolodny brettkolodny marked this pull request as ready for review September 5, 2025 14:36
DanielleMaywood
DanielleMaywood approved these changes Sep 5, 2025
View reviewed changes
Copy link
Contributor

@DanielleMaywood DanielleMaywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Non-blocking: It might be worth adding an extra test to ensure the command doesn't output users that the workspace isn't shared with. I realize this is probably already tested at the API level so not massively important to me

@brettkolodny
Copy link
Contributor Author

I realize this is probably already tested at the API level so not massively important to me

Yeah I had the same thought. It adds a lot more code to the tests and I don't think it'd be worth it when it's already being tested on API level

@brettkolodny brettkolodny merged commit 065c7c3 into main Sep 8, 2025
69 of 75 checks passed
@brettkolodny brettkolodny deleted the brett/i860 branch September 8, 2025 13:30
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DanielleMaywood DanielleMaywood DanielleMaywood approved these changes

Assignees

@brettkolodny brettkolodny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

coder sharing show command
2 participants
@brettkolodny @DanielleMaywood