refactor: replace deprecated Popovers which open on click #19709
+401
−271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgentOutdatedTooltip
IdpOrgSyncPageView, TableColumnHelpTooltip, TemplateInsightsPage
LegacyGroupSyncHeader
OrganizationBreadcrumb
This reverts commit c93e092.
PopoverClose from Popover component
aslilac
approved these changes
Sep 11, 2025
| @@ -102,7 +102,7 @@ export const UnselectingOption: Story = { | |||
| const canvas = within(canvasElement); | |||
| const button = canvas.getByRole("button"); | |||
| await userEvent.click(button); | |||
| const menu = canvasElement.querySelector<HTMLElement>("[role=menu]")!; | |||
| @@ -2,7 +2,7 @@ import { css } from "@emotion/css"; | |||
| import { type Theme, useTheme } from "@emotion/react"; | |||
| import { type DependencyList, useMemo } from "react"; | |||
|
|
|||
| export type ClassName = (cssFn: typeof css, theme: Theme) => string; | |||
| type ClassName = (cssFn: typeof css, theme: Theme) => string; | |||
There was a problem hiding this comment.
this means we're getting closer!! excited to see this old hack gone
Co-authored-by: ケイラ <mckayla@hey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #19397
dependency: #19635
This PR specifically covers components which open a popover that's triggered by a click, rather than a hover.