Skip to content

feat: Workspaces filtering #1972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Jun 3, 2022
Merged

feat: Workspaces filtering #1972

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
d7c1318
feat: Workspaces filtering
f0ssel Jun 1, 2022
5cb62d5
Remove error handling
f0ssel Jun 1, 2022
09011d9
styling
f0ssel Jun 1, 2022
11836ea
Apply suggestions from code review
f0ssel Jun 2, 2022
568e3a6
pr fixes
f0ssel Jun 2, 2022
f1409b2
language
f0ssel Jun 2, 2022
f8e09e6
push up what I have
f0ssel Jun 2, 2022
424e933
Add name filter to backend
f0ssel Jun 2, 2022
5dbf5b4
Add name filter
f0ssel Jun 2, 2022
2912d03
add backend
f0ssel Jun 2, 2022
9ea5c14
fix
f0ssel Jun 2, 2022
93a7d3c
Apply suggestions from code review
f0ssel Jun 2, 2022
79e71f1
fmt
f0ssel Jun 2, 2022
5f1ae06
Merge branch 'f0ssel/workspace-filter' of github.com:coder/coder into…
f0ssel Jun 2, 2022
6b2999d
trim query
f0ssel Jun 2, 2022
57fe5db
skip invalid key pairs
f0ssel Jun 2, 2022
0a5d972
fix pq type
f0ssel Jun 2, 2022
4aea7a0
fix tests
f0ssel Jun 2, 2022
0dd5552
make gen
f0ssel Jun 2, 2022
5d0d9bb
fix test
f0ssel Jun 2, 2022
59e7d5e
flicker less
f0ssel Jun 2, 2022
912b65c
some styling ideas (#2010)
Kira-Pilot Jun 3, 2022
30a17e9
fix lower comparison
f0ssel Jun 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test
  • Loading branch information
@f0ssel
f0ssel committed Jun 2, 2022
commit 5d0d9bbc91cab32e6e40a47615e8a7f1a1d5408c
3 changes: 2 additions & 1 deletion coderd/workspaces_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,8 @@ func TestWorkspacesByOwner(t *testing.T) {
require.Len(t, workspaces, 1)

// Create same name workspace that should be included
_ = coderdtest.CreateWorkspace(t, client, user.OrganizationID, template.ID, func(cwr *codersdk.CreateWorkspaceRequest) { cwr.Name = w.Name })
other := coderdtest.CreateAnotherUser(t, client, user.OrganizationID)
_ = coderdtest.CreateWorkspace(t, other, user.OrganizationID, template.ID, func(cwr *codersdk.CreateWorkspaceRequest) { cwr.Name = w.Name })

workspaces, err = client.Workspaces(context.Background(), codersdk.WorkspaceFilter{
Name: w.Name,
Expand Down