Skip to content

fix: prevent unruly stacking contexts from breaking scrolling #19785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2025
+7 −5
Merged

fix: prevent unruly stacking contexts from breaking scrolling #19785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfb4bde
Revert "fix: prevent new workspace page from scrolling past the botto…
aslilac Sep 11, 2025
4d7c935
fix: prevent unruly stacking contexts from breaking scrolling
aslilac Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions site/src/components/MultiSelectCombobox/MultiSelectCombobox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,3 +706,5 @@ export const MultiSelectCombobox = forwardRef<
);
},
);

MultiSelectCombobox.displayName = "MultiSelectCombobox";
2 changes: 1 addition & 1 deletion site/src/modules/dashboard/DashboardLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export const DashboardLayout: FC = () => {
<div className="flex flex-col h-screen justify-between">
<Navbar />

<div className="flex flex-col flex-1 min-h-0 overflow-y-auto">
<div className="relative flex flex-col flex-1 min-h-0 overflow-y-auto">
<Suspense fallback={<Loader />}>
<Outlet />
</Suspense>
Expand Down
8 changes: 4 additions & 4 deletions site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ export const CreateWorkspacePageViewExperimental: FC<
});

return (
<div className="flex flex-col flex-1 min-h-0 pb-12">
<>
<div className="sticky top-5 ml-10">
<button
onClick={onCancel}
Expand All @@ -351,7 +351,7 @@ export const CreateWorkspacePageViewExperimental: FC<
Go back
</button>
</div>
<div className="flex flex-col flex-1 min-h-0 gap-6 max-w-screen-md mx-auto">
<div className="flex flex-col gap-6 max-w-screen-md mx-auto">
<header className="flex flex-col items-start gap-3 mt-10">
<div className="flex items-center gap-2 justify-between w-full">
<span className="flex items-center gap-2">
Expand Down Expand Up @@ -412,7 +412,7 @@ export const CreateWorkspacePageViewExperimental: FC<
<form
onSubmit={form.handleSubmit}
aria-label="Create workspace form"
className="relative flex flex-col flex-1 min-h-0 overflow-y-auto gap-10 w-full border border-border-default border-solid rounded-lg p-6"
className="flex flex-col gap-10 w-full border border-border-default border-solid rounded-lg p-6"
>
{Boolean(error) && <ErrorAlert error={error} />}

Expand Down Expand Up @@ -683,6 +683,6 @@ export const CreateWorkspacePageViewExperimental: FC<
</div>
</form>
</div>
</div>
</>
);
};
Loading