feat: Use consistent colors for links and highlighting #1989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kira-Pilot
reviewed
Jun 2, 2022
| @@ -11,6 +11,7 @@ export const darkPalette: PaletteOptions = { | |||
| secondary: { | |||
| main: "#008510", | |||
| contrastText: "#f8f8f8", | |||
| dark: "#7057FF", | |||
Kira-Pilot
approved these changes
Jun 2, 2022
|
I'm wondering if we could also use it on our dropdown borders. It kind of bugs me that the border of the user dropdown is blue when the role chips are purple: |
@Kira-Pilot Sounds perfect! |
kylecarbs
pushed a commit
that referenced
this pull request
Jun 10, 2022
* feat: consistent highlight colors * update user dropdown menu border * update borderedmenurow active color
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the new purple color for highlighting links and other focus elements.
Subtasks
Fixes #1940
Screenshots
User roles
Side-navbar
Navbar
Builds table
User dropdown menu
This one is probably unused, but it was part of a story so updated it in case we end up using the component in the future:
