feature: Load workspace build logs from streaming #1997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kira-Pilot
reviewed
Jun 3, 2022
|
|
||
| // Watching for the stream | ||
| // eslint-disable-next-line no-constant-condition, @typescript-eslint/no-unnecessary-condition | ||
| while (true) { |
There was a problem hiding this comment.
Do we need to worry about error handling or cleanup if done never returns?
There was a problem hiding this comment.
It is a good point. I think for now we can rely on done being always called, why:
- We are using a polyfill(https://canjs.com/doc/can-ndjson-stream.html) because Firefox does not support some stream APIs
- I took a look and I didn't find anything related to "read failure" or something related
- If an error is thrown, it will stop the execution anyway
- This error, in particular, looks tricky to handle so I would expect someone having issues with that to think of a proper solution
- In summary, I don't know how to do that and it looks complex to handle 😆, so I would not invest too much time on that right now, but if you have an idea how to solve that, I would love to learn and implement it for sure.
There was a problem hiding this comment.
Ha! Thanks for the breakdown - what you said makes sense and I think you're right to hold off. If this becomes an issue in the future, we can look into calling cancel on the ReadableStream object.
Kira-Pilot
reviewed
Jun 3, 2022
|
|
||
| return ( | ||
| <div key={stage}> | ||
| <div className={styles.header}> | ||
| <div>{stage}</div> | ||
| {duration && <div className={styles.duration}>{duration} seconds</div>} | ||
| {shouldDisplaySpinner && <CircularProgress size={14} className={styles.spinner} />} | ||
| {shouldDisplayDuration && <div className={styles.duration}>{duration} seconds</div>} |
There was a problem hiding this comment.
should we put "seconds" in a Language block?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1769