fix: add copy fallback for insecure contexts #2044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm wondering if @mafredri can help us test :D |
mafredri
reviewed
Jun 6, 2022
There was a problem hiding this comment.
I tried this out and it doesn't seem to do anything on any of my browsers (Safari, Firefox, Brave). It also doesn't log anything in the console which would indicate result === true.
Perhaps input.hidden = true can't be selected? What if we use CSS to hide it instead?
PS. Thanks for taking a stab at fixing this @oxy!
8b26144 to
58cd3ed
Compare
58cd3ed to
b577731
Compare
d1c8346 to
2ee9f80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a clipboard copy fallback for insecure contexts.
Subtasks
Fixes #1601