Skip to content

example: add and document dotfiles usage #2046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 8, 2022
Merged

example: add and document dotfiles usage #2046

merged 3 commits into from
Jun 8, 2022

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented Jun 3, 2022

Closes #1765 #1274.

@bpmct bpmct requested a review from f0ssel June 3, 2022 19:37
@bpmct bpmct self-assigned this Jun 3, 2022
bpmct
bpmct commented Jun 3, 2022
View reviewed changes
f0ssel
f0ssel reviewed Jun 3, 2022
View reviewed changes
f0ssel
f0ssel approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@f0ssel f0ssel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Is there any way to simplify the template? Ideally we just want to highlight the usage of the startup_script parameter. But if not no biggie.

kylecarbs
kylecarbs reviewed Jun 3, 2022
View reviewed changes
@bpmct
Copy link
Member Author

bpmct commented Jun 6, 2022

@f0ssel - I've simplified the template, I agree we should just focus on dotfiles usage in the example.

However, two issues, which I think are related:

  1. the ssh key doesn't seem to be present in the machine at the time of startup_script
  2. the Coder binary is not present at the time of startup_script 
     /bin/bash: coder: No such file or directory
 coder: No such file or directory

However, when I ssh into the workspace, coder works. Any ideas?

@f0ssel
Copy link
Contributor

f0ssel commented Jun 6, 2022

@kylecarbs could you explain why this is the case? Are we running startup script via some other way than through coder agent?

@kylecarbs
Copy link
Member

The PATH just isn't being set when executing the startup script @f0ssel

@bpmct bpmct enabled auto-merge (squash) June 8, 2022 21:13
@bpmct bpmct merged commit 42c6b08 into main Jun 8, 2022
@bpmct bpmct deleted the bpmct/dotfiles-example branch June 8, 2022 21:23
@bpmct bpmct mentioned this pull request Jun 9, 2022
Closed
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@bpmct @kylecarbs
example: add and document dotfiles usage (#2046)
e53d02b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mafredri mafredri mafredri left review comments

@kylecarbs kylecarbs kylecarbs left review comments

@f0ssel f0ssel f0ssel approved these changes

Assignees

@bpmct bpmct

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

example: example template with dotfiles usage
4 participants
@bpmct @f0ssel @kylecarbs @mafredri