Skip to content

chore: version sub command remove --version and -v flag #2090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 6, 2022
Merged

chore: version sub command remove --version and -v flag #2090

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1c0cf42
feat: Reserve "-v" on root. Add "version" subcommand
Emyrk Jun 6, 2022
bec0e88
test: Add unit test for version cmd
Emyrk Jun 6, 2022
ae779c6
Fix test
Emyrk Jun 6, 2022
b509594
Only support 'coder version'
Emyrk Jun 6, 2022
273ad88
rename test
Emyrk Jun 6, 2022
5a6b0f2
Linter
Emyrk Jun 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Linter
  • Loading branch information
@Emyrk
Emyrk committed Jun 6, 2022
commit 5a6b0f284d33e0969c6fbfe361949b83deb20bbc
6 changes: 3 additions & 3 deletions cli/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,12 +117,12 @@ func versionCmd() *cobra.Command {
Example: "coder version",
RunE: func(cmd *cobra.Command, args []string) error {
var str strings.Builder
str.WriteString(fmt.Sprintf("Coder %s", buildinfo.Version()))
_, _ = str.WriteString(fmt.Sprintf("Coder %s", buildinfo.Version()))
buildTime, valid := buildinfo.Time()
if valid {
str.WriteString(" " + buildTime.Format(time.UnixDate))
_, _ = str.WriteString(" " + buildTime.Format(time.UnixDate))
}
str.WriteString("\r\n" + buildinfo.ExternalURL() + "\r\n")
_, _ = str.WriteString("\r\n" + buildinfo.ExternalURL() + "\r\n")

_, _ = fmt.Fprint(cmd.OutOrStdout(), str.String())
return nil
Expand Down