Skip to content

chore: split release workflow so the majority happens on Linux #2092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 7, 2022
Merged

chore: split release workflow so the majority happens on Linux #2092

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
be842a0
chore: split release workflow so the majority happens on Linux
deansheather Jun 6, 2022
9ddb587
fixup! chore: split release workflow so the majority happens on Linux
deansheather Jun 6, 2022
2b8d9cb
chore: add dry-run functionality to release workflow
deansheather Jun 6, 2022
d638c6e
fixup! chore: add dry-run functionality to release workflow
deansheather Jun 6, 2022
ec1064b
fixup! chore: add dry-run functionality to release workflow
deansheather Jun 6, 2022
6b09749
fixup! chore: add dry-run functionality to release workflow
deansheather Jun 6, 2022
8d0992d
chore: add retry for apple notarization
deansheather Jun 6, 2022
5cf8b28
fixup! chore: add retry for apple notarization
deansheather Jun 6, 2022
ea01e6e
fixup! chore: add retry for apple notarization
deansheather Jun 6, 2022
2116601
fixup! chore: add retry for apple notarization
deansheather Jun 6, 2022
2c3a65a
fixup! chore: add retry for apple notarization
deansheather Jun 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: add retry for apple notarization
  • Loading branch information
@deansheather
deansheather committed Jun 6, 2022
commit 8d0992d555cd03f5f703d2db67f1ef6df1d0bcc6
21 changes: 20 additions & 1 deletion scripts/sign_macos.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,23 @@ jq -r --null-input --arg path "$(pwd)/$1" '{
}
]
}' >"$config"
gon "$config"

# The notarization process is very fragile and heavily dependent on Apple's
# notarization server not returning server errors, so we retry this step 5
# times with a delay of 30 seconds between each attempt.
rc=0
for i in $(seq 1 5); do
gon "$config" && rc=0 && break || rc=$?
echo "gon exit code: $rc"
if [ "$i" -lt 5 ]; then
echo
echo "Retrying notarization in 30 seconds"
echo
sleep 30
else
echo
echo "Giving up :("
fi
done

exit $rc