fix: add workspace option 'deleted' to options type #2095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deansheather
approved these changes
Jun 6, 2022
Kira-Pilot
approved these changes
Jun 6, 2022
kylecarbs
pushed a commit
that referenced
this pull request
Jun 10, 2022
* fix: add workspace option 'deleted' to options type * dead code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not generating the
deletedquery param option for the frontend to consume, so this changes that.I've also removed the 400 error code if you provide
?deleted=truebut the workspace isn't in a deleted state. I think it's easier for the frontend to provide this unconditionally for some pages and not need to juggle the changing error states.