Skip to content

fix: Stop showing resources after coder create #2155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Jun 8, 2022

This change avoids a confusing UX where the workspace agent shows "connecting" after create has completed.

Fixes #1036


Output:

Select a template below to preview the provisioned
infrastructure:

  This template has customizable parameters. Values can be
  changed after create, but may have unintended side effects
  (like data loss).

var.docker_image
  Which Docker image would you like to use for your workspace?

  >  codercom/enterprise-base:ubuntu

Planning workspace...
✔ Queued [15ms]
✔ Setting up [500ms]
✔ Detecting persistent resources [1431ms]
✔ Cleaning Up [0ms]
┌──────────────────────────────────────────────────────────┐
│ Workspace Preview                                        │
├──────────────────────────────────────────────────────────┤
│ RESOURCE                    STATUS     ACCESS            │
├──────────────────────────────────────────────────────────┤
│ docker_container.workspace  ephemeral                    │
│ └─ dev (linux, )                        coder ssh test2  │
├──────────────────────────────────────────────────────────┤
│ docker_volume.home_volume   ephemeral                    │
└──────────────────────────────────────────────────────────┘
> Confirm create? (yes/no)
✔ Queued [136ms]
✔ Setting up [6ms]
⧗  Starting workspace
  Terraform 1.1.9
  coder_agent.dev: Plan to create
  docker_volume.home_volume: Plan to create
  docker_container.workspace[0]: Plan to create
  Plan: 3 to add, 0 to change, 0 to destroy.
  coder_agent.dev: Creating...
  coder_agent.dev: Creation complete after 0s [id=a76f21f8-1fc8-4990-b498-70dd97da2563]
  docker_volume.home_volume: Creating...
  docker_volume.home_volume: Creation complete after 0s [id=coder-maf-test2-root]
  docker_container.workspace[0]: Creating...
  docker_container.workspace[0]: Creation complete after 1s [id=a9ac14a867d28bcace2fe1b3c2eb747dda33994b6a586b2e9ab30b18250a776e]
  Apply complete! Resources: 3 added, 0 changed, 0 destroyed.
  Outputs: 0
✔ Starting workspace [2916ms]
✔ Cleaning Up [-5ms]

The test2 workspace has been created!

This change avoids a confusing UX where the workspace agent shows
"connecting" after create has completed.

Fixes #1036
@mafredri mafredri self-assigned this Jun 8, 2022
@mafredri mafredri requested review from f0ssel, spikecurtis and a team June 8, 2022 09:59
@mafredri mafredri merged commit 2621093 into main Jun 9, 2022
@mafredri mafredri deleted the mafredri/skip-showing-resources-after-coder-create branch June 9, 2022 07:44
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Final output on workspace creation shows "connecting" forever - confusing UX
4 participants