fix: Improve Terraform agent<->resource association testing #2187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3f63dce to
5821ab5
Compare
There were a few bugs with multiple agent association this fixes, and it adds thorough tests using real Terraform state and plans.
b7eb9b5 to
b208e8e
Compare
|
Does this encompass the bugs discovered in #1884? |
b208e8e to
88f08b7
Compare
|
@bpmct yup! |
88f08b7 to
4fa9a3b
Compare
f0ssel
approved these changes
Jun 8, 2022
deansheather
approved these changes
Jun 8, 2022
| set -euo pipefail | ||
| cd "$(dirname "${BASH_SOURCE[0]}")" | ||
|
|
||
| for d in */; do |
There was a problem hiding this comment.
I appreciate that you've included the script for this :)
mafredri
added a commit
that referenced
this pull request
Jun 9, 2022
kylecarbs
added a commit
that referenced
this pull request
Jun 9, 2022
This was regressed in #2187. There was bad testing around this before, and this should prevent a similiar situation from happening again!
kylecarbs
added a commit
that referenced
this pull request
Jun 9, 2022
This was regressed in #2187. There was bad testing around this before, and this should prevent a similiar situation from happening again!
kylecarbs
added a commit
that referenced
this pull request
Jun 9, 2022
This was regressed in #2187. There was bad testing around this before, and this should prevent a similiar situation from happening again!
kylecarbs
added a commit
that referenced
this pull request
Jun 10, 2022
kylecarbs
pushed a commit
that referenced
this pull request
Jun 10, 2022
kylecarbs
added a commit
that referenced
this pull request
Jun 10, 2022
This was regressed in #2187. There was bad testing around this before, and this should prevent a similiar situation from happening again!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An agent could be associated with multiple resources prior to this, which broke all workspace access (and doesn't make any sense). This adds tests based on Terraform output. The raw Terraform statefiles are pushed for fast testing, and can be iterated on by editing the Terraform and running
generate.sh.This should improve test times and provide a much more stable solution for resource association!