Skip to content

feat: show deleted workspace after delete action #2208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 9, 2022

Conversation

Kira-Pilot
Copy link
Member

Resolves #1955
Kapture 2022-06-09 at 09 54 45

@Kira-Pilot Kira-Pilot marked this pull request as ready for review June 9, 2022 15:30
@Kira-Pilot Kira-Pilot requested a review from a team as a code owner June 9, 2022 15:31
Copy link
Contributor

@greyscaled greyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🥳

@Kira-Pilot Kira-Pilot merged commit 518495a into main Jun 9, 2022
@Kira-Pilot Kira-Pilot deleted the show-deleted-workspace/kira-pilot branch June 9, 2022 15:43
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
* added deleted workspace banner

* x state pass

* added include_deleted param

* clean up x state

* added teests

* cleaning up unneeded xstate service
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete awkwardness and 410 error instead of taking user to Workspaces list after deleting the workspace
2 participants