Skip to content

fix: initialValues for ws schedule #2213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 9, 2022
Merged

fix: initialValues for ws schedule #2213

merged 2 commits into from
Jun 9, 2022

Conversation

greyscaled
Copy link
Contributor

Summary:

When a schedule is not set, we default to M-F, 5 hours ttl

@greyscaled
fix: initialValues for ws schedule
337a7da 
Summary:

When a schedule is not set, we default to M-F, 5 hours ttl
@greyscaled greyscaled requested a review from a team as a code owner June 9, 2022 18:03
@greyscaled greyscaled requested review from johnstcn and removed request for a team June 9, 2022 18:03
@greyscaled greyscaled self-assigned this Jun 9, 2022
johnstcn
johnstcn approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd even go for 8 hours on TTL, unless there's an explicit reason for 5.

@greyscaled greyscaled merged commit 377f17c into main Jun 9, 2022
@greyscaled greyscaled deleted the vapurrmaid/fix-initialValues-schedule branch June 9, 2022 19:20
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@greyscaled @kylecarbs
fix: initialValues for ws schedule (#2213)
2a35186 
Summary:

When a schedule is not set, we default to M-F, 5 hours ttl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnstcn johnstcn johnstcn approved these changes

Assignees

@greyscaled greyscaled

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greyscaled @johnstcn