Skip to content

Make coder bump idempotent #2225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Make coder bump idempotent #2225

merged 1 commit into from
Jun 10, 2022

Conversation

ammario
Copy link
Member

@ammario ammario commented Jun 10, 2022

Resolves #2223

In addition to solving what's outlined in the issue,
I remove the client-side minute check because it had no
clear purpose when the API already returns an error.

Resolves #2223

In addition to solving what's outlined in the issue,
I remove the client-side minute check because it had no
clear purpose when the API already returns an error.
@ammario ammario requested a review from johnstcn June 10, 2022 01:36
@ammario ammario merged commit 0df75f9 into main Jun 10, 2022
@ammario ammario deleted the improve-bump branch June 10, 2022 03:30
@ammario ammario restored the improve-bump branch June 10, 2022 03:30
ammario added a commit that referenced this pull request Jun 10, 2022
This reverts commit 0df75f9.

I merged on accident.
@johnstcn
Copy link
Member

Note: this was reverted in 6ea86c8

@ammario ammario deleted the improve-bump branch June 10, 2022 08:31
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
Resolves #2223

In addition to solving what's outlined in the issue,
I remove the client-side minute check because it had no
clear purpose when the API already returns an error.
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
This reverts commit 0df75f9.

I merged on accident.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

coder bump should not stack bumps
2 participants