Skip to content

chore: edit CLI/UI copy #2247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jun 16, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: fix issues w/ merge conflict resolution
  • Loading branch information
Katie Horne committed Jun 14, 2022
commit dd94acab0f48c250f9445557628c9d5d8f445407
4 changes: 0 additions & 4 deletions site/src/api/typesGenerated.ts
Original file line number Diff line number Diff line change
Expand Up @@ -247,11 +247,7 @@ export interface Template {
readonly description: string
readonly max_ttl_ms: number
readonly min_autostart_interval_ms: number
<<<<<<< HEAD
readonly created_by_id?: string
=======
readonly created_by_id: string
>>>>>>> main
readonly created_by_name: string
}

Expand Down
9 changes: 0 additions & 9 deletions site/src/components/TemplateStats/TemplateStats.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,3 @@ UsedByMany.args = {
},
activeVersion: Mocks.MockTemplateVersion,
}

export const UnknownCreator = Template.bind({})
UnknownCreator.args = {
template: {
...Mocks.MockTemplate,
created_by_name: "",
},
activeVersion: Mocks.MockTemplateVersion,
}
8 changes: 0 additions & 8 deletions site/src/components/TemplateStats/TemplateStats.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@ const Language = {
userPlural: "users",
userSingular: "user",
createdByLabel: "Created by",
<<<<<<< HEAD
defaultTemplateCreator: "<unknown>",
=======
>>>>>>> main
}

export interface TemplateStatsProps {
Expand Down Expand Up @@ -53,11 +49,7 @@ export const TemplateStats: FC<TemplateStatsProps> = ({ template, activeVersion
<div className={styles.statsDivider} />
<div className={styles.statItem}>
<span className={styles.statsLabel}>{Language.createdByLabel}</span>
<<<<<<< HEAD
<span className={styles.statsValue}>{template.created_by_name || Language.defaultTemplateCreator}</span>
=======
<span className={styles.statsValue}>{template.created_by_name}</span>
>>>>>>> main
</div>
</div>
)
Expand Down
16 changes: 0 additions & 16 deletions site/src/pages/TemplatesPage/TemplatesPageView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,7 @@ import {
HelpTooltipLinksGroup,
HelpTooltipText,
HelpTooltipTitle,
<<<<<<< HEAD
} from "../../components/Tooltips/HelpTooltip/HelpTooltip"
=======
} from "../../components/HelpTooltip/HelpTooltip"
import { Margins } from "../../components/Margins/Margins"
import { PageHeader, PageHeaderSubtitle, PageHeaderTitle } from "../../components/PageHeader/PageHeader"
import { Stack } from "../../components/Stack/Stack"
import { TableLoader } from "../../components/TableLoader/TableLoader"
>>>>>>> main

dayjs.extend(relativeTime)

Expand All @@ -58,10 +50,6 @@ export const Language = {
templateTooltipText: "With templates you can create a common configuration for your workspaces using Terraform.",
templateTooltipLink: "Manage templates",
createdByLabel: "Created by",
<<<<<<< HEAD
defaultTemplateCreator: "<unknown>",
=======
>>>>>>> main
}

const TemplateHelpTooltip: React.FC = () => {
Expand Down Expand Up @@ -151,11 +139,7 @@ export const TemplatesPageView: FC<TemplatesPageViewProps> = (props) => {
<TableCell>{Language.developerCount(template.workspace_owner_count)}</TableCell>

<TableCell data-chromatic="ignore">{dayjs().to(dayjs(template.updated_at))}</TableCell>
<<<<<<< HEAD
<TableCell>{template.created_by_name || Language.defaultTemplateCreator}</TableCell>
=======
<TableCell>{template.created_by_name}</TableCell>
>>>>>>> main
<TableCell>
<div className={styles.arrowCell}>
<KeyboardArrowRight className={styles.arrowRight} />
Expand Down
22 changes: 0 additions & 22 deletions site/src/pages/WorkspacesPage/WorkspacesPageView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,7 @@ import {
HelpTooltipLinksGroup,
HelpTooltipText,
HelpTooltipTitle,
<<<<<<< HEAD
} from "../../components/Tooltips/HelpTooltip/HelpTooltip"
=======
} from "../../components/HelpTooltip/HelpTooltip"
import { Margins } from "../../components/Margins/Margins"
import { PageHeader, PageHeaderSubtitle, PageHeaderTitle } from "../../components/PageHeader/PageHeader"
import { Stack } from "../../components/Stack/Stack"
import { TableLoader } from "../../components/TableLoader/TableLoader"
>>>>>>> main
import { getFormHelpers, onChangeTrimmed } from "../../util/formUtils"
import { getDisplayStatus, workspaceFilterQuery } from "../../util/workspace"

Expand Down Expand Up @@ -138,21 +130,7 @@ export const WorkspacesPageView: FC<WorkspacesPageViewProps> = ({ loading, works

return (
<Margins>
<<<<<<< HEAD
<PageHeader
actions={
<PageHeaderText>
Create a new workspace from a{" "}
<Link component={RouterLink} to="/templates">
template
</Link>
.
</PageHeaderText>
}
>
=======
<PageHeader>
>>>>>>> main
<PageHeaderTitle>
<Stack direction="row" spacing={1} alignItems="center">
<span>Workspaces</span>
Expand Down