feat: gzip static http server assets #2272
Conversation
Agent binary downloads go from 30MB to 13MB!
There was a problem hiding this comment.
Nice, I was thinking we should do this as I was investigating #2202, glad you got around to it!
PS. I don't think the use of middleware here is a blocker (i.e. we can go ahead with gziphandler), but I do think supporting more than gzip may be beneficial in the browser environment (considering we're serving the entire site package behind the handler).
coderd/coderd.go
Outdated
| @@ -350,7 +351,8 @@ func New(options *Options) *API { | |||
| r.Get("/state", api.workspaceBuildState) | |||
| }) | |||
| }) | |||
| r.NotFound(api.siteHandler.ServeHTTP) | |||
|
|
|||
| r.NotFound(gziphandler.GzipHandler(http.HandlerFunc(api.siteHandler.ServeHTTP)).ServeHTTP) | |||
There was a problem hiding this comment.
Any reason to prefer gziphandler vs chi/middleware.Compress here? The Chi one also supports deflate. (I think it would be nice to support all of: deflate, gzip and br (brotli), but chi does not handle br.)
There was a problem hiding this comment.
Ah, that one looks better!
|
We should def remove this once we start to actually store gzip'd assets, but this is a pretty quick win especially when using the dev tunnel. |
Agent binary downloads go from 30MB to 13MB!