feat: Add anonymized telemetry to report product usage #2273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a background service to report telemetry to a Coder server for usage data. There will be realtime event data sent in the future, but for now usage will report on a CRON.
coadler
approved these changes
Jun 12, 2022
| @@ -0,0 +1,4 @@ | |||
| CREATE TABLE IF NOT EXISTS site_config ( | |||
| key varchar(256) NOT NULL UNIQUE, | |||
| value varchar(8192) NOT NULL | |||
There was a problem hiding this comment.
Using jsonb as the value would make it much easier in the future to do migrations on structured data. We've needed to do this a couple times in v1.
coderd/telemetry/telemetry.go
Outdated
| emailHashed := "" | ||
| atSymbol := strings.LastIndex(dbUser.Email, "@") | ||
| if atSymbol >= 0 { | ||
| hash := sha256.Sum256([]byte(dbUser.Email[:atSymbol])) |
There was a problem hiding this comment.
This hash seems easily reversible tbh. What if we just used {user_id}@domain.com?
There was a problem hiding this comment.
I want it to be traceable across deployments. We could use a greater hash, but I agree it's still crackable regardless.
There was a problem hiding this comment.
Ah yeah, I forgot about that. This seems reasonable then.
There was a problem hiding this comment.
I'll add a comment here for that
ad19dce to
b7b0833
Compare
Closed
79f5490 to
8b1eef8
Compare
af8190a to
61f6c6f
Compare
fbc9edf to
c333174
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a background service to report telemetry to a Coder
server for usage data. There will be realtime event data sent
in the future, but for now usage will report on a CRON.