Skip to content

refactor: Replace PageHeaderText by PageHeaderSubtitle #2287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

Preview:
Screen Shot 2022-06-13 at 13 46 56

You can see all the visual changes in Chromatic.

@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner June 13, 2022 16:47
<PageHeaderTitle>
<Stack direction="row" spacing={1} alignItems="center">
<span>Workspaces</span>
<WorkspaceHelpTooltip />
</Stack>
</PageHeaderTitle>

<PageHeaderSubtitle>
Create a new workspace from a{" "}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these belong in Language?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge this for now, but I promise I will get back to move this to Language.

Copy link
Member

@Kira-Pilot Kira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@BrunoQuaresma BrunoQuaresma merged commit 9d15584 into main Jun 13, 2022
@BrunoQuaresma BrunoQuaresma deleted the bq/replace-page-header-text-by-subtitle branch June 13, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants