Skip to content

chore: Add some more error context in cli #2301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2022
Merged

chore: Add some more error context in cli #2301

merged 1 commit into from
Jun 13, 2022

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Jun 13, 2022

We probably need to revisit our errors more generally.
This is better than the status quo.

Before

> Upload "../../examples/templates/docker"? (yes/no) yes
terraform (info): 
terraform (info): 
terraform (info): 
job failed

After

> Upload "../../examples/templates/docker"? (yes/no) yes
terraform (info): 
terraform (info): 
terraform (info): 
job failed: missing parameter: new_var

@Emyrk Emyrk merged commit 1863da4 into main Jun 13, 2022
@Emyrk Emyrk deleted the stevenmasley/template_error_cli branch June 13, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Emyrk @kylecarbs