feat: Add built-in PostgreSQL for simple production setup #2345

kylecarbs · 2022-06-15T15:28:17Z

Fixes #2321.

This removes dev-mode too! See the issue for rationale. I manually tested this on Linux and Windows too!

`coder server`

`coder server --postgres-builtin` (first run)

`coder server --postgres-builtin` (subsequent run)

`coder server --postgres-builtin --tunnel`

`coder server postgres-builtin-url`

im-coder-lg · 2022-06-15T16:52:41Z

Wait, so it's just prod for dev envs? Maybe why not add a flag for wiping all user data, like on dev mode?

im-coder-lg · 2022-06-15T17:05:22Z

That could help if a person was just testing Coder OSS. So, my final question is this: how do you actually get Coder into prod on machines? Running this is one thing, but how do you control Postgres to make it deployable? Last time I ran it, it gave an error of not giving passwords, when I just installed it a few minutes ago! I almost got it working, but it still failed. This could help, but a guide would be needed if we need to detail and make people understand how this has to work.

Whoa got an idea(devilish grin in a positive way), this is a great PR btw!

Fixes #2321.

mafredri

Wow, surprised at how little changes were needed, nice! (PS. I did not try running this, only reviewed the code.)

cli/server.go

coderd/provisionerdaemons.go

cli/login.go

bpmct · 2022-06-15T18:41:45Z

README.md

+# Automatically sets up PostgreSQL and an external access URL on *.try.coder.app
+coder server --postgres-builtin --tunnel


Suggested change

# Automatically sets up PostgreSQL and an external access URL on *.try.coder.app

coder server --postgres-builtin --tunnel

# Simple) Automatically sets up PostgreSQL and an external access URL on *.try.coder.app

coder server --postgres-builtin --tunnel

I think this helps indicate they are separate options and not commands to be run sequentially

bpmct · 2022-06-15T18:41:58Z

README.md

+# Requires a PostgreSQL instance and external access URL
+coder server --postgres-url <url> --access-url <url>


Suggested change

# Requires a PostgreSQL instance and external access URL

coder server --postgres-url <url> --access-url <url>

# Advanced) Requires a PostgreSQL instance and external access URL

coder server --postgres-url <url> --access-url <url>

bpmct · 2022-06-15T18:42:39Z

README.md

+# Automatically sets up PostgreSQL and an external access URL on *.try.coder.app
+coder server --postgres-builtin --tunnel


I think this helps indicate they are separate options and not commands to be run sequentially

bpmct · 2022-06-15T18:43:34Z

cli/server_test.go

 	})

 	t.Run("NoWarningWithRemoteAccessURL", func(t *testing.T) {
 		t.Parallel()
 		ctx, cancelFunc := context.WithCancel(context.Background())
 		defer cancelFunc()

-		root, cfg := clitest.New(t, "server", "--dev", "--tunnel=false", "--address", ":0", "--access-url", "http://1.2.3.4:3000/")
+		root, cfg := clitest.New(t, "server", "--in-memory", "--address", ":0", "--access-url", "http://1.2.3.4:3000/")


So --in-memory still exists

It does but is primarily used for testing.

f0ssel · 2022-06-15T19:20:21Z

README.md

@@ -47,10 +47,14 @@ To install, run:
 curl -fsSL https://coder.com/install.sh | sh
 ```

-Once installed, you can run a temporary deployment in dev mode (all data is in-memory and destroyed on exit):
+Once installed, you can start a production deployment with a single command:


Sorry, but turning the DB off if the single instance of the app goes down is not what a lot of people would consider "production"

We do essentially this same thing right now on our dogfood deployment, which I'd consider a production deployment of Coder.

I agree with @f0ssel here -- I'd be more comfortable with a "traditionally-managed" database if I were setting up a prod deployment than just using the embedded one. Doesn't detract from the value of being able to instantly kick the tyres with a real database!

Why though? I believe users should start real, production deployments with this setup. There isn't a technical reason why it's bad practice. Users can just backup the ~/.config/coder/postgres directory on a CRON.

Coupling the lifecycle of the database to the app lifecycle and running the DB on the same host are two pretty big red flags for any engineers that have to actually manage and troubleshoot the app in production.

What are the specific red flags? You can still run the database independently.

I'm saying that if a customer wanting to run 1000 devs and it be production ready I'd probably advise them:

Run the DB on a dedicated host

Run regular database backups and have a restore process

Run multiple instances of the app server, optionally on multiple hosts behind a LB, optionally across different AZs.

Have a way to run new webserver versions without causing downtime

Right now this command not only does none of those things, but also won't even allow you to run multiple instances of the web app since it will conflict on the DB setup.

And similar to why people recommend not putting DB healthchecks in the webserver healthchecks on kubernetes - you don't want your DB taking your webapp down and vice versa, you want their lifecycles independent for obvious reasons.

provisionerd/provisionerd.go

.goreleaser.yaml

kylecarbs requested review from mafredri, johnstcn and bpmct June 15, 2022 15:28

kylecarbs requested a review from a team as a code owner June 15, 2022 15:28

kylecarbs self-assigned this Jun 15, 2022

kylecarbs force-pushed the embeddeddb branch 5 times, most recently from 6f71825 to fd66daf Compare June 15, 2022 16:30

feat: Add built-in PostgreSQL for simple production setup

dc122b6

Fixes #2321.

kylecarbs force-pushed the embeddeddb branch 2 times, most recently from 5211334 to 39fe970 Compare June 15, 2022 18:34

mafredri approved these changes Jun 15, 2022

View reviewed changes

cli/server.go Outdated Show resolved Hide resolved

coderd/provisionerdaemons.go Outdated Show resolved Hide resolved

cli/login.go Outdated Show resolved Hide resolved

bpmct reviewed Jun 15, 2022

View reviewed changes

bpmct approved these changes Jun 15, 2022

View reviewed changes

f0ssel reviewed Jun 15, 2022

View reviewed changes

johnstcn reviewed Jun 15, 2022

View reviewed changes

provisionerd/provisionerd.go Show resolved Hide resolved

johnstcn reviewed Jun 15, 2022

View reviewed changes

.goreleaser.yaml Show resolved Hide resolved

Merge branch 'main' into embeddeddb

0450fcb

kylecarbs force-pushed the embeddeddb branch from 39fe970 to 0450fcb Compare June 15, 2022 19:40

kylecarbs added 3 commits June 15, 2022 19:44

Merge branch 'main' into embeddeddb

0856209

Use fork of embedded-postgres for cache path

7fd3560

Merge branch 'main' into embeddeddb

690c791

kylecarbs force-pushed the embeddeddb branch from 8e9b259 to 690c791 Compare June 15, 2022 20:40

johnstcn approved these changes Jun 15, 2022

View reviewed changes

kylecarbs merged commit ccd0616 into main Jun 15, 2022

kylecarbs deleted the embeddeddb branch June 15, 2022 21:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add built-in PostgreSQL for simple production setup #2345

feat: Add built-in PostgreSQL for simple production setup #2345

kylecarbs commented Jun 15, 2022 •

edited

Loading

im-coder-lg commented Jun 15, 2022

im-coder-lg commented Jun 15, 2022

mafredri left a comment

bpmct Jun 15, 2022

bpmct Jun 15, 2022

bpmct Jun 15, 2022

bpmct Jun 15, 2022

bpmct Jun 15, 2022

kylecarbs Jun 15, 2022

f0ssel Jun 15, 2022

kylecarbs Jun 15, 2022

kylecarbs Jun 15, 2022

johnstcn Jun 15, 2022

kylecarbs Jun 15, 2022

kylecarbs Jun 15, 2022

f0ssel Jun 15, 2022 •

edited

Loading

kylecarbs Jun 15, 2022

f0ssel Jun 15, 2022 •

edited

Loading

f0ssel Jun 15, 2022

		# Automatically sets up PostgreSQL and an external access URL on *.try.coder.app
		coder server --postgres-builtin --tunnel

		# Requires a PostgreSQL instance and external access URL
		coder server --postgres-url <url> --access-url <url>

feat: Add built-in PostgreSQL for simple production setup #2345

feat: Add built-in PostgreSQL for simple production setup #2345

Conversation

kylecarbs commented Jun 15, 2022 • edited Loading

coder server

coder server --postgres-builtin (first run)

coder server --postgres-builtin (subsequent run)

coder server --postgres-builtin --tunnel

coder server postgres-builtin-url

im-coder-lg commented Jun 15, 2022

im-coder-lg commented Jun 15, 2022

mafredri left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

f0ssel Jun 15, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

f0ssel Jun 15, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kylecarbs commented Jun 15, 2022 •

edited

Loading

`coder server`

`coder server --postgres-builtin` (first run)

`coder server --postgres-builtin` (subsequent run)

`coder server --postgres-builtin --tunnel`

`coder server postgres-builtin-url`

f0ssel Jun 15, 2022 •

edited

Loading

f0ssel Jun 15, 2022 •

edited

Loading