Skip to content

feat: Implement parameters list + more template list columns #2359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 15, 2022
Merged

feat: Implement parameters list + more template list columns #2359

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
15b4dc8
feat: Implement parameters list
Emyrk Jun 15, 2022
642bfd2
Hide param list by default for now
Emyrk Jun 15, 2022
0e81573
Cleanup
Emyrk Jun 15, 2022
1f8c14c
Add comment
Emyrk Jun 15, 2022
4487877
Make gen
Emyrk Jun 15, 2022
2b83388
Import order
Emyrk Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cleanup
  • Loading branch information
@Emyrk
Emyrk committed Jun 15, 2022
commit 0e81573f038c153e1ec0141176d8dac70e9c257c
6 changes: 3 additions & 3 deletions cli/parameters.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
package cli

import (
"github.com/coder/coder/cli/cliui"
"github.com/coder/coder/codersdk"
"github.com/jedib0t/go-pretty/v6/table"
"github.com/spf13/cobra"

"github.com/coder/coder/cli/cliui"
"github.com/coder/coder/codersdk"
)

func parameters() *cobra.Command {
Expand Down Expand Up @@ -33,7 +34,6 @@ func displayParameters(filterColumns []string, params ...codersdk.Parameter) str
Name: "name",
}})
for _, param := range params {
//fmt.Println(param, filterColumns)
tableWriter.AppendRow(table.Row{
param.ID.String(),
param.Scope,
Expand Down
5 changes: 3 additions & 2 deletions cli/parameterslist.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@ import (
"github.com/google/uuid"
"golang.org/x/xerrors"

"github.com/coder/coder/codersdk"
"github.com/spf13/cobra"

"github.com/coder/coder/codersdk"
)

func parameterList() *cobra.Command {
Expand Down Expand Up @@ -58,7 +59,7 @@ func parameterList() *cobra.Command {
})
}

params, err := client.Parameters(cmd.Context(), codersdk.ParameterScope(args[0]), scopeID)
params, err := client.Parameters(cmd.Context(), codersdk.ParameterScope(scope), scopeID)
if err != nil {
return xerrors.Errorf("fetch params: %w", err)
}
Expand Down