Skip to content

fix: Forms - Add 'escape' button / key handler in forms #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 16, 2022
Merged

fix: Forms - Add 'escape' button / key handler in forms #240

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
38f0dea
fix: Add FormCloseButton for project / workspace create forms
bryphe-coder Feb 10, 2022
b532d93
Tweak styling
bryphe-coder Feb 10, 2022
19fb01b
Clean up tests
bryphe-coder Feb 10, 2022
ed80c22
Fix lint issues
bryphe-coder Feb 10, 2022
7a0bf9c
Merge branch 'main' into bryphe/fix/add-esc-handler
bryphe-coder Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clean up tests
  • Loading branch information
@bryphe-coder
bryphe-coder committed Feb 10, 2022
commit 19fb01b754fd05225c469c8b3c28f5bf5fcae0e0
3 changes: 3 additions & 0 deletions site/components/Form/FormCloseButton.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,11 @@ describe("FormCloseButton", () => {

// Then
const element = await screen.findByText("ESC")

// When
fireEvent.click(element)

// Then
expect(onClose).toBeCalledTimes(1)
})

Expand Down