Skip to content

feat: cli: consolidate schedule-related commands #2402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 16, 2022
Merged

feat: cli: consolidate schedule-related commands #2402

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
70cec9d
feat: cli: consolidate schedule-related commands
johnstcn Jun 15, 2022
b2e8f15
fixup! feat: cli: consolidate schedule-related commands
johnstcn Jun 16, 2022
8fa27aa
Makefile: test-postgres: increase timeout and parallelism
johnstcn Jun 16, 2022
ae6c047
make lint
johnstcn Jun 16, 2022
f817751
more tests, some cli tweaks
johnstcn Jun 16, 2022
f6f8de0
update schedule override output to match other commands
johnstcn Jun 16, 2022
dad6695
show time until deadline
johnstcn Jun 16, 2022
bf1bafd
bump test timeout
johnstcn Jun 16, 2022
3441dab
Merge remote-tracking branch 'origin/main' into cj/2258/cli-schedule-…
johnstcn Jun 16, 2022
81b2656
address PR comments
johnstcn Jun 16, 2022
dc16686
address PR comments
johnstcn Jun 16, 2022
aced9da
Merge remote-tracking branch 'origin/main' into cj/2258/cli-schedule-…
johnstcn Jun 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make lint
  • Loading branch information
@johnstcn
johnstcn committed Jun 16, 2022
commit ae6c047c0a82b528d8935bc46c75d0864d4a4f74
3 changes: 1 addition & 2 deletions cli/schedule.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ func scheduleStop() *cobra.Command {
return err
}

var durMillis *int64 = nil
var durMillis *int64
if args[1] != "manual" {
dur, err := parseDuration(args[1])
if err != nil {
Expand Down Expand Up @@ -299,5 +299,4 @@ func displaySchedule(workspace codersdk.Workspace, out io.Writer) error {

_, _ = fmt.Fprintln(out, tw.Render())
return nil

}
2 changes: 1 addition & 1 deletion cli/schedule_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ func TestScheduleShow(t *testing.T) {
)

// unset workspace TTL
require.NoError(t, client.UpdateWorkspaceTTL(ctx, workspace.ID, codersdk.UpdateWorkspaceTTLRequest{nil}))
require.NoError(t, client.UpdateWorkspaceTTL(ctx, workspace.ID, codersdk.UpdateWorkspaceTTLRequest{TTLMillis: nil}))

cmd, root := clitest.New(t, cmdArgs...)
clitest.SetupConfig(t, client, root)
Expand Down