Skip to content

feat: Show help tooltip on hover #2423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 17, 2022
Merged

feat: Show help tooltip on hover #2423

merged 3 commits into from
Jun 17, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

Closes #2148

@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner June 16, 2022 17:23
@BrunoQuaresma BrunoQuaresma self-assigned this Jun 16, 2022
@presleyp
Copy link
Contributor

I'm having trouble running v2 right now, but I checked the storybook, and I saw two weird things:

  1. backticks around an apostrophe in the tooltip text
  2. the tooltip shows up slightly lower in the Open story than it does when I just hover in the Closed story

@BrunoQuaresma
Copy link
Collaborator Author

@presleyp thanks for noticing that.

  • Fixed
  • I'm not able to reproduce the "lower" thing. Maybe what is happening is: that since it is open by default you have to enter again and leave to see the action happening.

@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) June 17, 2022 12:42
@BrunoQuaresma BrunoQuaresma merged commit d0aca86 into main Jun 17, 2022
@BrunoQuaresma BrunoQuaresma deleted the bq/tooltip-on-hover branch June 17, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kira-Pilot Kira-Pilot Kira-Pilot approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question Mark helpers should appear on hover instead of on click
3 participants
@BrunoQuaresma @presleyp @Kira-Pilot