Skip to content

fix: Start login shells on macOS and Linux #2437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 17, 2022
Merged

fix: Start login shells on macOS and Linux #2437

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4479de2
fix: Start login shells on macOS and Linux
kylecarbs Jun 16, 2022
1bd2ade
Fix expansion on Windows
kylecarbs Jun 17, 2022
3880934
Merge branch 'main' into loginshell
kylecarbs Jun 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix expansion on Windows
  • Loading branch information
@kylecarbs
kylecarbs committed Jun 17, 2022
commit 1bd2ade89d54c7d8f9ad6d89ade75488c5a418db
6 changes: 5 additions & 1 deletion agent/agent_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,12 @@ func TestAgent(t *testing.T) {
}
output, err := session.Output(command)
require.NoError(t, err)
expect := ""
if runtime.GOOS == "windows" {
expect = "%EXAMPLE%"
}
// Output should be empty, because the variable is not set!
require.Equal(t, "", strings.TrimSpace(string(output)))
require.Equal(t, expect, strings.TrimSpace(string(output)))
})

t.Run("StartupScript", func(t *testing.T) {
Expand Down