Skip to content

fix: Add reaper to coder agent #2441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 17, 2022
Merged

fix: Add reaper to coder agent #2441

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
99ab87e
fix: Add reaper to coder agent
sreya Jun 16, 2022
5330e8c
add some comments
sreya Jun 16, 2022
b1cc536
add doc.go
sreya Jun 16, 2022
1703e6d
fix test
sreya Jun 16, 2022
2806ab9
try again
sreya Jun 16, 2022
8f2fa52
skip non-linux OS
sreya Jun 16, 2022
85d0635
Improve env marker and code conventions
sreya Jun 16, 2022
41e0165
make windows-specific stubs
sreya Jun 16, 2022
757257c
linux only
sreya Jun 16, 2022
282b583
typo
sreya Jun 16, 2022
fb11daf
whoops
sreya Jun 16, 2022
c66d7be
skip reaper tests in CI
sreya Jun 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
skip reaper tests in CI
  • Loading branch information
@sreya
sreya committed Jun 17, 2022
commit c66d7be8a424aa60535d12d568ffb86cbb0fe975
8 changes: 8 additions & 0 deletions agent/reaper/reaper_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
package reaper_test

import (
"os"
"os/exec"
"testing"
"time"
Expand All @@ -16,6 +17,13 @@ import (
func TestReap(t *testing.T) {
t.Parallel()

// Don't run the reaper test in CI. It does weird
// things like forkexecing which may have unintended
// consequences in CI.
if _, ok := os.LookupEnv("CI"); ok {
t.Skip("Detected CI, skipping reaper tests")
}

// Because we're forkexecing these tests will try to run twice...
if reaper.IsChild() {
t.Skip("I'm a child!")
Expand Down