fixing type for ParameterSchema

resolves #2161
coder · Kira-Pilot · Jun 17, 2022 · Jun 14, 2022 · Jun 15, 2022 · Jun 15, 2022
commit f8dcb1b2ec3c8ba0e186b226e350b9fdca6cccd6
diff --git a/codersdk/parameters.go b/codersdk/parameters.go
@@ -72,7 +72,7 @@ type ParameterSchema struct {
 
 	// This is a special array of items provided if the validation condition
 	// explicitly states the value must be one of a set.
-	ValidationContains []string `json:"validation_contains"`
+	ValidationContains []string `json:"validation_contains,omitempty"`
 }
 
 // CreateParameterRequest is used to create a new parameter value for a scope.

diff --git a/site/src/api/typesGenerated.ts b/site/src/api/typesGenerated.ts
@@ -190,7 +190,7 @@ export interface ParameterSchema {
   readonly validation_condition: string
   readonly validation_type_system: string
   readonly validation_value_type: string
-  readonly validation_contains: string[]
+  readonly validation_contains?: string[]
 }
 
 // From codersdk/provisionerdaemons.go:33:6

diff --git a/site/src/components/ParameterInput/ParameterInput.tsx b/site/src/components/ParameterInput/ParameterInput.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-unnecessary-condition */
 import FormControlLabel from "@material-ui/core/FormControlLabel"
 import Radio from "@material-ui/core/Radio"
 import RadioGroup from "@material-ui/core/RadioGroup"
@@ -38,16 +37,15 @@ const ParameterField: React.FC<ParameterInputProps> = ({ disabled, onChange, sch
           onChange(event.target.value)
         }}
       >
-        {schema.validation_contains &&
-          schema.validation_contains.map((item) => (
-            <FormControlLabel
-              disabled={disabled}
-              key={item}
-              value={item}
-              control={<Radio color="primary" size="small" disableRipple />}
-              label={item}
-            />
-          ))}
+        {schema.validation_contains.map((item) => (
+          <FormControlLabel
+            disabled={disabled}
+            key={item}
+            value={item}
+            control={<Radio color="primary" size="small" disableRipple />}
+            label={item}
+          />
+        ))}
       </RadioGroup>
     )
   }