feat: Clean up coder agent path in ps listing
#2453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the `coder agent` path in `ps` listing from `/tmp/tmp.coderwWs87Y/coder agent` to `./coder agent`. The path is also updated to `/tmp/coder.wWs87Y`. There were two options considered for turning `./coder agent` into `coder agent`: 1. Run `exec -a coder /path/to/coder agent` 2. Run `PATH=/path/to:$PATH exec coder agent` Option 1 is not supported by `dash`, and thus discarded. Option 2 duplicates functionality in `coder agent` which _appends_ the path, here we would want to _prepend_ it to ensure we're starting the downloaded `coder` binary in case there is a binary with a conflicting name on the system. Fixes #2407
johnstcn
approved these changes
Jun 17, 2022
I thought about the possibility of modifying it from the agent (or having the agent re-exec), but I don't think we want to change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the
coder agentpath inpslisting from/tmp/tmp.coderwWs87Y/coder agentto./coder agent.The path is also updated to
/tmp/coder.wWs87Y.There were two options considered for turning
./coder agentintocoder agent:exec -a coder /path/to/coder agentPATH=/path/to:$PATH exec coder agentOption 1 is not supported by
dash, and thus discarded.Option 2 duplicates functionality in
coder agentwhich appends thepath, here we would want to prepend it to ensure we're starting the
downloaded
coderbinary in case there is a binary with a conflictingname on the system.
Fixes #2407