Lock the fake database during transactions #2478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spike Curtis <spike@coder.com>
Emyrk
reviewed
Jun 17, 2022
| // inTxMutex is a no op, since inside a transaction we are already locked. | ||
| type inTxMutex struct{} | ||
|
|
||
| func (_ *inTxMutex) Lock() {} |
There was a problem hiding this comment.
Even more lazy.
Suggested change
| func (_ *inTxMutex) Lock() {} | |
| func (nTxMutex) Lock() {} |
Signed-off-by: Spike Curtis <spike@coder.com>
…fake_db_transaction_isolation
Signed-off-by: Spike Curtis <spike@coder.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might fix #2436 entirely, but definitely will fix in the fake db case.
There are additional bugs lurking around basically every use of InTx() in our tests that this fixes, because until this PR, transactions exposed intermediate state to other goroutines with the fake database.