chore: apply non-durability settings to test postgres container #2479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit applies some recommended settings to sacrifice durability for speed for our testing database: - Mount PGDATA dir on a tmpfs (--tmpfs /tmp) - Turn off fsync - Turn off synchronous_commit - Turn off full_page_writes Ref: https://www.postgresql.org/docs/current/non-durability.html
johnstcn
commented
Jun 17, 2022
| @@ -127,13 +127,17 @@ test-postgres-docker: | |||
| --env POSTGRES_USER=postgres \ | |||
| --env POSTGRES_DB=postgres \ | |||
| --env PGDATA=/tmp \ | |||
| --tmpfs /tmp \ | |||
There was a problem hiding this comment.
This was apparently not a tmpfs before!
mafredri
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit applies some recommended settings to sacrifice durability
for speed for our testing database:
Ref: https://www.postgresql.org/docs/current/non-durability.html
You can argue that if we are already storing the tmpfs in memory, why do we want the other stuff to avoid disk I/O?
My response is:
I tested this out in my v2 workspace (template=coder)
Before: average runtime = 146.6s (N=3)
After: average runtime = 106.4s (N=3)